Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KerningFitSpacing when rendering Character Panel text #7692

Open
vlolteanu opened this issue Feb 1, 2025 · 0 comments · May be fixed by #7706
Open

Use KerningFitSpacing when rendering Character Panel text #7692

vlolteanu opened this issue Feb 1, 2025 · 0 comments · May be fixed by #7706

Comments

@vlolteanu
Copy link
Contributor

vlolteanu commented Feb 1, 2025 •
edited by StephenCWills
Loading

Some panel text is hard to fit in the appropriate boxes. Currently, spacing is hardcoded based on string length. However, there's a "kosher" approach:

How do we determine spacing in the Info Panel?

We just pass UiFlags::KerningFitSpacing into DrawString(). The rendering function figures out what the spacing should be by computing the width of the string before rendering and comparing it to the size of the bounding box for the text.

Originally posted by @StephenCWills in #7688 (comment)
@StephenCWills StephenCWills changed the title Use KerningFitSpacing when rendering panel text Use KerningFitSpacing when rendering Character Panel text Feb 2, 2025
@kphoenix137 kphoenix137 linked a pull request Feb 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Character Panel Number spacing kphoenix137/devilutionX
1 participant
@vlolteanu