Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key printscreen or snapshot without function since 0.31.2 #373

Open
tripfish opened this issue Dec 6, 2022 · 4 comments
Open

Key printscreen or snapshot without function since 0.31.2 #373

tripfish opened this issue Dec 6, 2022 · 4 comments
Assignees
Labels
Error Unexpected replicated behavior Windows Issues regarding Microsoft Windows OS

Comments

@tripfish
Copy link

tripfish commented Dec 6, 2022

Hey, since version 0.31.2 the Key action with printscreen or snapshot does not work anymore.

Version 0.31.2:

VK  SC	Type	Up/Dn	Elapsed	Key
---------------------------------------------
FF  154	a	d	12.33	^              	
FF  154	a	u	0.00	^    

Version 0.31.1:

VK  SC	Type	Up/Dn	Elapsed	Key
---------------------------------------------
2C  154	a	d	3.97	PrintScreen    	
2C  154	a	u	0.00	PrintScreen

Windows 10 64 Bit
DPI 15.3

@drmfinlay
Copy link
Member

Hello @tripfish,

Thank you for reporting this issue. I can confirm that this key is broken in versions after 0.31.1. It is also broken on the master branch. I should be able to fix this in the next version.

@drmfinlay drmfinlay self-assigned this Dec 8, 2022
@drmfinlay drmfinlay added Error Unexpected replicated behavior Windows Issues regarding Microsoft Windows OS labels Dec 8, 2022
drmfinlay added a commit that referenced this issue Dec 8, 2022
Re: #373.

The 'printscreen' / 'snapshot' and 'numlock' keys are now typeable,
via Key action objects, on Windows again.
@drmfinlay
Copy link
Member

This is now fixed on the master branch. I wrote a program for testing simulated keystrokes from Dragonfly with the AutoHotkey KeybdHook utility and managed to catch another key that doesn't work properly: numlock. I have fixed this one too.

The npsep (VK_SEPARATOR) key might also need to be treated as a "soft" key as per my commit, but I am unable to test it.

@tripfish
Copy link
Author

tripfish commented Dec 8, 2022

Thanks for the quick bug fix.
I have just tested the change. Both keys are working. 👍

What is VK_SEPARATOR? Even if I run it directly as win32api.keybd_event, it has no function on my system.

@drmfinlay
Copy link
Member

No worries. Thanks for testing the change.

VK_SEPARATOR is the keycode for the number pad separator key. Hence, Dragonfly's name for it (npsep). According to this SO answer it is available on "Brazilian and some Far East keyboards," but not US keyboards.

I was able to simulate and bind the key to a Windows shortcut. So it does work, it just doesn't produce any output. Autohotkey doesn't know what it is either, which was why I brought it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Unexpected replicated behavior Windows Issues regarding Microsoft Windows OS
Projects
None yet
Development

No branches or pull requests

2 participants