Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: windows 3.11-13 fail due to lack of libdiffpy on conda-forge #51

Open
bobleesj opened this issue Jan 21, 2025 · 4 comments
Open

CI: windows 3.11-13 fail due to lack of libdiffpy on conda-forge #51

bobleesj opened this issue Jan 21, 2025 · 4 comments

Comments

@bobleesj
Copy link

bobleesj commented Jan 21, 2025

Image

@sbillinge while Windows CI runs fail while others succeed

Turns out indeed there is no libdiffpy for windows: https://anaconda.org/conda-forge/libdiffpy/files

Should we proceed with sk-packaging without windows?

@bobleesj
Copy link
Author

I see Tieqiong's current work: diffpy/libdiffpy#35

@bobleesj
Copy link
Author

(I was looking into sk-packaging clustermining -> srfit needed -> srreal needed -> libdiffpy needed..)

@sbillinge
Copy link
Contributor

@bobleesj I am not sure what your question is, but our current top priority is getting srreal working on windows on conda-forge. This we have never managed to do, and it unlocks everything.

If the question is about repackaging clustermining, let's wait, though we could start the boring part of the process (black, moving files to src, tests out of the package, etc.). We won't have the satisfaction of taking everything all the way to conda-forge at p3.13, but that boring work has to be done anyway, and it tests that part of sk-package. I leave that up to you.

@sbillinge
Copy link
Contributor

clustermining has the addtitional interesting wrinkle that we want to move it to a diffpy namespace package, so it also tests again that part of the workflow (we did it before with Fourigui, but that was much earlier in the life of cookiecutter.....)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants