Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we store the root key? #25

Open
achou11 opened this issue Jul 3, 2024 · 3 comments
Open

How do we store the root key? #25

achou11 opened this issue Jul 3, 2024 · 3 comments

Comments

@achou11
Copy link
Member

achou11 commented Jul 3, 2024

On mobile, we use Expo's SecureStore API to handle storage of the rootkey that's passed to core. We need something similar for desktop, where we securely store the key on a device level. The key is sensitive and therefore it does not seem appropriate to store it via electron-store (see note in docs).

Seems like safeStorage is the technically sound option? Minor concern is that it requires some user-intervention, which has UX consequences (at least on macOS, where it prompts you to enter your root password in order to let the app access the keychain).

Open to other options and thoughts. Haven't explored the ecosystem too much so maybe there's something that's appropriate that I missed.

@achou11
Copy link
Member Author

achou11 commented Jul 4, 2024

@gmaclennan any thoughts on this?

@gmaclennan
Copy link
Member

The docs seem incorrect or misleading? The docs say you need the system keyring password (eg the root password), but the description of the protection from other users suggests that what it means is users keyring password? I think it is worth creating a test app with just safestorage to verify what it actually looks like.

@achou11
Copy link
Member Author

achou11 commented Jul 4, 2024

yeah i tried it out and i believe it's the user's keyring password (at least on macOS)

my decision to use the "root" wording in the issue description was a little careless, fwiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants