Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to retrieve documentLoader #52

Closed
kezike opened this issue Oct 28, 2021 · 3 comments
Closed

Unable to retrieve documentLoader #52

kezike opened this issue Oct 28, 2021 · 3 comments

Comments

@kezike
Copy link

kezike commented Oct 28, 2021

Are we supposed to provide our own document loader as an option input to encode and decode? This line suggests that documentLoader is provided by this library, but this value appears to be undefined 🤔
@dmitrizagidulin
Copy link
Contributor

@kezike - ah, thanks for the catch. Yes, the user is supposed to provide their own documentLoader; I'll update the README to reflect that

@wip-abramson
Copy link

I also ran into this issue just now

@dlongley
Copy link
Member

dlongley commented Aug 6, 2024

I pushed a quick update to the README to remove the documentLoader import and a comment in the example to mention the user must provide it. We need additional README updates for the new API features and I've filed #92 for that. Closing this issue based on these changes.

@dlongley dlongley closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dlongley @dmitrizagidulin @kezike @wip-abramson