Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a serving multiplexer to serve both web and grpc requests on the same port #40

Merged
merged 1 commit into from
May 26, 2024

Conversation

dinowernli
Copy link
Owner

@dinowernli dinowernli commented Apr 10, 2023

This PR adds an HTTP serving layer to the service started on each port. The (very basic) serving knows how to return the value and version associated with a key, as seen by the KeyValue store on the corresponding server.

Example URL to query for after running the main binary: http://localhost:12345/keyvalue/get?key=foo

@dinowernli dinowernli force-pushed the http-server branch 4 times, most recently from e29f72d to 0298e27 Compare April 10, 2023 17:44
@dinowernli dinowernli changed the title Add a serving multiplexer to server both web and grpc requests on the same port Add a serving multiplexer to serve both web and grpc requests on the same port Apr 10, 2023
@dinowernli dinowernli force-pushed the http-server branch 4 times, most recently from 139a00c to c21e907 Compare May 4, 2024 15:32
@dinowernli dinowernli force-pushed the http-server branch 2 times, most recently from 0759875 to ce0b9bb Compare May 12, 2024 21:44
@dinowernli dinowernli force-pushed the http-server branch 7 times, most recently from 06a5d04 to e87594b Compare May 26, 2024 10:57
@dinowernli dinowernli marked this pull request as ready for review May 26, 2024 11:05
@dinowernli dinowernli merged commit f97fc31 into master May 26, 2024
2 checks passed
@dinowernli dinowernli deleted the http-server branch May 26, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant