Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Component]: Minimize Absolute Positioning on the Donate Page Hero #288

Open
jtfairbank opened this issue Dec 19, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@jtfairbank
Copy link
Contributor

Attempt to minimize the amount of content that is absolute positioned. Based on the design, it seems like you could divide the content into 3 sections:

  1. The "support us today" content in a relatively positioned wrapper with a blue background and top padding.
  2. The "ship aid to people in need" content in a relatively positioned wrapper with a white background (the content itself would have the purple background).
  3. The hero image, which could be absolutely positioned. Though you might be able to get away with including it in # 2 and using relative positioning to move it up.

Code:

  • Make changes to src/components/donate/HeroSection.tsx.
  • See src/components/tech/HeroSection.tsx and src/components/tech/AboutHero.tsx for examples.
@jtfairbank jtfairbank added the enhancement New feature or request label Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Triage in DA Tech Dec 19, 2024
@jtfairbank jtfairbank moved this from Triage to Ready for Work in DA Tech Dec 19, 2024
@hcavanaugh hcavanaugh changed the title Minimize Absolute Positioning on the Donate Page Hero Fix: Minimize Absolute Positioning on the Donate Page Hero Feb 5, 2025
@hcavanaugh hcavanaugh changed the title Fix: Minimize Absolute Positioning on the Donate Page Hero Fix [Component]: Minimize Absolute Positioning on the Donate Page Hero Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for Work
Development

No branches or pull requests

2 participants