Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony 7 compatibility #42

Open
daften opened this issue Jan 18, 2025 · 4 comments
Open

Add Symfony 7 compatibility #42

daften opened this issue Jan 18, 2025 · 4 comments

Comments

@daften
Copy link
Contributor

daften commented Jan 18, 2025

Now this causes issues on Drupal 11.1 because Symfony 7.2 is needed and this package is not compatible with that.

@Jelle-S
Copy link
Collaborator

Jelle-S commented Jan 20, 2025

Right now this is blocked by gordalina/cachetool#238 because robo-digipolis-deploy depends on it.

@daften
Copy link
Contributor Author

daften commented Jan 20, 2025

True, but support could be built in here and in a repo a fork could be added "as gordalina/cachetool" to allow updating :)

@Jelle-S
Copy link
Collaborator

Jelle-S commented Jan 23, 2025

@daften could you try 5.0.0-alpha1?

@daften
Copy link
Contributor Author

daften commented Jan 23, 2025

There's some more issues for the full chain:

  • digipolisgent/robo-digipolis-drupal8 still requires digipolisgent/robo-digipolis-helpers ^4
  • digipolisgent/robo-drush and digipolisgent/robo-digipolis-package-drupal8 don't allow consolidation/robo ^5, which prevents symfony 7 compatibility
  • digipolisgent/robo-drush doesn't allow drush 13
  • digipolisgent/robo-digipolis-package-drupal8 has 2.0.0-alpha1, but that's not released on packagist

In the end this repositories part for composer.json with the command below worked for me:

        "robo-drush": {
            "type": "vcs",
            "url": "https://github.com/daften/robo-drush.git"
        },
        "cachetool": {
            "type": "vcs",
            "url": "https://github.com/Chris53897/cachetool.git"
        },
        "robo-digipolis-package-drupal8": {
            "type": "vcs",
            "url": "https://github.com/district09/robo-digipolis-package-drupal8.git"
        }

composer require digipolisgent/robo-digipolis-drupal8:4.0.9 digipolisgent/robo-digipolis-helpers:"5.0.0-alpha1 as 4.1.1" digipolisgent/robo-drush:"dev-feature/update as 5.1.0" gordalina/cachetool:"dev-feature/symfony-7 as 9.2.1" digipolisgent/robo-digipolis-package-drupal8:"2.0.0-alpha1 as 1.0.1" consolidation/robo:^5 -W --verbose

I didn't open a PR, because one test for robo-drush fails and I didn't have time to fix it yet, could just be phpunit upgrades I did that caused it too, it's because of a change in phpunit 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants