Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compatibility with custom images #1454

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

W1ldPo1nter
Copy link
Contributor

Description

Fixes the issue mentioned below. As suggested in that thread, I moved the generation of the expand link into the Python code, so that it gets passed to the template via context (which also moves logic from the template to the view layer, which should be a good thing).

While implementing the fix and testing via tox, I found that:

  • the recent changes to the filer_check command were not compatible with a custom image model either
  • while the tox tests have a flag to test with or without a swapped image model, the CI tests running via GitHub actions do not, meaning that there aren't any automated tests with a swapped image model right now

Therefore, I took the liberty to fix the mentioned command and extended the test action matrix with a flag for the image model swap (similar to the tox setup), so that problems with a custom image model have a chance to be caught automatically.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.90%. Comparing base (b0f39ab) to head (acd03e8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
+ Coverage   76.59%   76.90%   +0.31%     
==========================================
  Files          75       75              
  Lines        3546     3551       +5     
  Branches      568      570       +2     
==========================================
+ Hits         2716     2731      +15     
+ Misses        667      660       -7     
+ Partials      163      160       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrief jrief merged commit fa385bd into django-cms:master Mar 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants