fix: Compatibility with custom images #1454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue mentioned below. As suggested in that thread, I moved the generation of the expand link into the Python code, so that it gets passed to the template via context (which also moves logic from the template to the view layer, which should be a good thing).
While implementing the fix and testing via tox, I found that:
filer_check
command were not compatible with a custom image model eitherTherefore, I took the liberty to fix the mentioned command and extended the test action matrix with a flag for the image model swap (similar to the tox setup), so that problems with a custom image model have a chance to be caught automatically.
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.