ANSI escape sequences rendered in error messages

[ibuclaw]

This doesn't look like it should be intended behaviour.

static assert(0, "\x1b[31mThis should be red");

https://compiler-explorer.com/z/9f5oKM1j9

[thewilsonator]

@dkorpel did you fix this?

[dkorpel]

No, the string contents of static assert messages / pragma msg is still passed directly to stderr.

I'm contemplating what the best fix is here: we could filter out these characters, but when the user explicitly puts these in the message, why not respect that? In that case, just resetting the color after printing a static assert message will do.

Are there other funky characters we should watch out for?

[thewilsonator]

direction overrides (LtR, RtL)?, cc @rikkimax anything else that comes to mind?

[rikkimax]

In general, I would say if people are putting ANSI escape sequences in their outputs from DMD, that's on them.

However, what does come to mind is that dub has code that converts ANSI escape sequences to the Windows API call equivalent.
This may be of interest.