Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Sanitize plugin config logs when Options contain secrets #697

Open
kaufers opened this issue Sep 22, 2017 · 0 comments
Open

Sanitize plugin config logs when Options contain secrets #697

kaufers opened this issue Sep 22, 2017 · 0 comments

Comments

@kaufers
Copy link
Contributor

kaufers commented Sep 22, 2017

PR #694 added support to pull in vars from a file (using a template); the idea is that the data in the file would be the clear text cloud provider credentials.

This data is logged in the following locations, the actual content has been removed and replaced with <snip>:

DBUG[09-22|14:43:01] rendered                                 module=cli/core view="<snip>" 
stack="[github.com/docker/infrakit/pkg/cli/services.go:207 
github.com/docker/infrakit/cmd/infrakit/plugin/plugin.go:155 
github.com/docker/infrakit/vendor/github.com/spf13/cobra/command.go:632 
github.com/docker/infrakit/vendor/github.com/spf13/cobra/command.go:722 
github.com/docker/infrakit/vendor/github.com/spf13/cobra/command.go:681 
infrakit/main.go:166]" fn=github.com/docker/infrakit/pkg/cli.templateProcessor.func3

DBUG[09-22|14:43:01] exec                                     module=launch/inproc key=terraform pn=terraform config="<snip>" 
stack="[github.com/docker/infrakit/pkg/launch/inproc/inproc.go:149 
github.com/docker/infrakit/pkg/launch/monitor.go:198]" 
fn=github.com/docker/infrakit/pkg/launch/inproc.(*Launcher).Exec

DBUG[09-22|14:43:01] about to run                             module=launch/inproc key=terraform name=terraform config="<snip>" 
stack="[github.com/docker/infrakit/pkg/launch/inproc/inproc.go:164 
github.com/docker/infrakit/pkg/launch/monitor.go:198]" 
fn=github.com/docker/infrakit/pkg/launch/inproc.(*Launcher).Exec

DBUG[09-22|14:43:03] instance_rpc.PluginServer                module=run pp="&{Dir:/infrakit_files fs:0x2f26448 fsLock:/infrakit_files/tf-apply.lck applying:true applyLock:{state:0 sema:0} pretend:false pollInterval:60000000000 pollChannel:0xc420246d20 pluginLookup:0x1a18c80 envs:[<snip>]}" stack="[github.com/docker/infrakit/pkg/run/rpc.go:99 
github.com/docker/infrakit/pkg/launch/inproc/inproc.go:173 
github.com/docker/infrakit/pkg/launch/monitor.go:198]" 
fn=github.com/docker/infrakit/pkg/run.ServeRPC

INFO[09-22|14:43:03] Waiting for startup                      module=core/launch key=terraform name=terraform config="<snip>" as=terraform stack=
[github.com/docker/infrakit/pkg/launch/monitor.go:207] 
fn=github.com/docker/infrakit/pkg/launch.(*Monitor).Start.func1

Can the logs be sanitized so that the secrets are not in the infrakit logs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant