Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Use only container instead external storage (volume or host mapping) #880

Open
Krzysztof318 opened this issue Nov 12, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Krzysztof318
Copy link

Is your proposal related to a problem?

Currently each container uses docker volumes or we can optionally map it to host path.

Describe the solution you'd like.

Allowing disable external storage and store all windows files with container. Of course it will cause containers will very big, but then we can easly use docker commit to create container image as checkpoint purpose. Currently for using this for testing software is a bit inconvenient because everytime I create new fresh container for testing it reinstall whole system. If I can create custom container image after installation with docket commit it should be much faster to create new fresh containers for software testing.

Describe alternatives you've considered.

Manually backup docker volumes.

Additional context

No response

@Krzysztof318 Krzysztof318 added the enhancement New feature or request label Nov 12, 2024
@kroese
Copy link
Contributor

kroese commented Nov 12, 2024

Very good idea, I will add this to the next version!

@kroese
Copy link
Contributor

kroese commented Nov 13, 2024

This now added in v4.03 if you set:

environment:
  COMMIT: "Y"

Try it out and let me know if it works!

@kroese
Copy link
Contributor

kroese commented Nov 13, 2024

@Krzysztof318 That is because the container is based on qemu-docker, you can see the relevant changes here: qemus/qemu-docker@5497893

@Krzysztof318
Copy link
Author

Krzysztof318 commented Nov 13, 2024

It works but commiting with docker is almost impossible, hangs on commit command, anyway your patch works, just docker has a problem with commit huge image about 64gb.

@edit
Creating image took 15 minutes

@Krzysztof318
Copy link
Author

@kroese Could you also disable creating empty volume and remove iso file after installation?

@Krzysztof318
Copy link
Author

I am not docker and linux speciallist but image from container shouldn't be smaller? data.img is growable disk so, why it takes full size when docker commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants