Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SequencerConfig usage #2467

Closed
tcoratger opened this issue Sep 23, 2024 · 6 comments
Closed

remove SequencerConfig usage #2467

tcoratger opened this issue Sep 23, 2024 · 6 comments

Comments

@tcoratger
Copy link
Contributor

SequencerConfig is marked as in the process of removal in

// TODO: just a placeholder for now, remove until we have a dedicated class for building node
// components
#[deprecated = "In the process of removal"]
#[derive(Debug, Default)]
pub struct SequencerConfig {
pub block_time: Option<u64>,
pub no_mining: bool,
#[cfg(feature = "messaging")]
pub messaging: Option<crate::service::messaging::MessagingConfig>,
}

There are still a few places in the code where this structure is used, for example here:

pub async fn start(config: SequencerConfig, starknet_config: StarknetConfig) -> Self {

In order to fully deprecate this type, we need to remove uses like this.

@Jonatan-Chaverri
Copy link
Contributor

I will like to work on this

@kariy
Copy link
Member

kariy commented Sep 23, 2024

I will like to work on this

hey @Jonatan-Chaverri, im still figuring out that part as i refactor stuff around. so not really thinking of opening it to external contributor for now.

if you want to contribute, i'd suggest trying this one instead #2458

@ScottyDavies
Copy link

ScottyDavies commented Sep 24, 2024

@tcoratger can i take up this issue

@Sagar-Puniyani
Copy link

@tcoratger want to work on this issue assign it to me

@kariy
Copy link
Member

kariy commented Sep 30, 2024

@ScottyDavies @Sagar-Puniyani sorry guys, we're not accepting external contributors for this issue for now.

@kariy
Copy link
Member

kariy commented Oct 9, 2024

the entire config management has been revamped here #2508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants