Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing all icons #362

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow customizing all icons #362

wants to merge 3 commits into from

Conversation

mohkale
Copy link
Contributor

@mohkale mohkale commented May 14, 2023 •
edited
Loading

CLOSES #361

@mohkale mohkale marked this pull request as ready for review May 14, 2023 16:45
@mohkale
Copy link
Contributor Author

mohkale commented Jun 10, 2023

Ping @domtronn .

@mohkale
Copy link
Contributor Author

mohkale commented Aug 13, 2023

Ping @domtronn

@mohkale
Copy link
Contributor Author

mohkale commented Feb 10, 2024

Ping @wyuenho

@mohkale
feat: Make all icons customizeable
a8fdd4a 
Add customizeable variables for all the icons inserted by all-the-icons
that previously were hardcoded into the functions that used them.
@mohkale
refactor: Add helper for overriding icon args
6062361
@wyuenho
Copy link
Collaborator

wyuenho commented Jun 23, 2024

I'm going to hold off on this large change. The future SVG branch is going to allow customizing all icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow customising all possible icons
2 participants
@mohkale @wyuenho