-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{{asset 'scripts'}} helper #3
Comments
Not a bad idea, maybe |
thinking about it a bit more this isn't really want {{asset}} is for. {{asset}} is for 3rd party libraries to create DOM elements that are associated with something that is loaded as part of the page lifecycle. For example done-css registers styles using That being said, another helper that makes it easier to add the steal script tag is a good idea. Maybe something like: {{steal cacheVersion=12}} defaulting to node_modules/steal/steal.js in dev and node_modules/steal/steal.production.js in production. |
We don't have the {{asset}} helper any more. But what done-ssr should do is add the appropriate script tags for you in production. It can consume the bundle graph that steal-tools will be exporting. |
Currently there is only two asset helpers. When looking at the layout page, instead of having to add
Every time, could we just add an
Helper that implements that logic (using
require('package.json').main
as the main for production)?The text was updated successfully, but these errors were encountered: