Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshopt doesn't find meshoptimizer npm package #615

Closed
hybridherbst opened this issue Jul 9, 2022 · 3 comments · Fixed by #617
Closed

meshopt doesn't find meshoptimizer npm package #615

hybridherbst opened this issue Jul 9, 2022 · 3 comments · Fixed by #617
Labels
bug Something isn't working package:cli
Milestone

Comments

@hybridherbst
Copy link

hybridherbst commented Jul 9, 2022

Describe the bug
I'm trying to use gltf-transform meshopt via CLI.
It errors with

error: meshopt: encoder dependency required — install "meshoptimizer".

which I'm happy to do

npm install -g meshoptimizer

but the error persists. Is there a way to use the CLI for gltf-transform meshopt? I kind of remember using that in the past.
The code just mentions an encoder has to be passed in, which I think I can't do for the CLI:

To Reproduce
Steps to reproduce the behavior:

  1. Use the CLI to compress any glb with gltf-transform meshopt MyFile.glb MyFile.meshopt.glb

Expected behavior
Some way to use gltf-transform meshopt via CLI

Versions:

  • Version: 2.1.7
  • Environment: CLI

Additional context
I think this might be a regression

@donmccurdy
Copy link
Owner

Does look like a regression, thanks! Should be fixed by #617.

@donmccurdy donmccurdy added this to the v2.1 milestone Jul 9, 2022
@donmccurdy
Copy link
Owner

Published to v2.1.8, thanks for reporting the issue! 🙏🏻

@hybridherbst
Copy link
Author

Wow, that was fast - thanks!
Also happy to see that gltf-transform meshopt doesn't have this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants