Remove blinking arrow and add message for empty categories #245
+32
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…play message when no snippets are found
ACR1209
requested review from
psychlone77,
saminjay and
Mathys-Gasnier
as code owners
|
Hey, there. Thanks for fixing it. We will be able to merge the PR once we successfully implement the search feature on #159. Because it's a pretty big PR with a lot of changes. |
Okay, will be on the lookout in case of conflicts |
Search PR is successfully merged. Feel free to resolve the conflicts and we should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the blinking arrow that sometimes appeared when changing language and add a message when the category has no snippets.
Type of Change
Checklist
Related Issues
Closes #241
Additional Context
I simply don't render the spinner as the time it's present it makes the blinking happen either way and with
AnimatePresenceit looks good to me.Screenshots (Optional)
Click to view screenshots