-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-nullable fields on an input object type #9960
Comments
I'm not sure about this check either. Non-Nullable fields on input objects seem to be allowed in the spec, there are even examples of it in the spec. I don't get the reason of this check. |
That makes a lot of sense, thanks for clarifying! |
@eddeee888 Ah sorry for the misunderstanding, thanks for clearing that up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
graphql-code-generator/packages/plugins/typescript/typescript/src/visitor.ts
Lines 333 to 335 in d49124e
Is this part of the GraphQL spec or is it an opinion? Would there be a lot of pushback to removing this check?
Describe the solution you'd like
Remove this check.
Describe alternatives you've considered
No response
Is your feature request related to a problem? Please describe.
No response
The text was updated successfully, but these errors were encountered: