Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All dashboards with cluster variable is broken in VictoriaMetrics [bug] #83

Closed
Krelion opened this issue Dec 19, 2023 · 6 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Krelion
Copy link

Krelion commented Dec 19, 2023

Describe the bug

Popup message in grafana when opening dashboards:

Templating
Failed to upgrade legacy queries Datasource prometheus was not found

Previsious version working fine

How to reproduce?

Install VictoriaMetrics as prometheus datasource and try open namespace dashboard

Expected behavior

Dashboards works correctly

Additional context

No response

@Krelion Krelion added the bug Something isn't working label Dec 19, 2023
@dotdc
Copy link
Owner

dotdc commented Dec 19, 2023

Hi @Krelion,

Thank you for reporting the issue, this bug was introduced by changes made yesterday.
Just merged #84, could you try the latest version and let me know if it works on your VictoriaMetrics setup?

@Krelion
Copy link
Author

Krelion commented Dec 19, 2023

Everything works well, thanks!

@Krelion
Copy link
Author

Krelion commented Dec 19, 2023

Can you add tags for new versions so that our code can reference the exact version?

@dotdc
Copy link
Owner

dotdc commented Dec 19, 2023

You mean manage a release for the entire set using git tags?

@Krelion
Copy link
Author

Krelion commented Dec 19, 2023

You mean manage a release for the entire set using git tags?

yes

@dotdc
Copy link
Owner

dotdc commented Dec 20, 2023

Sure, I can do that. Can you use master in the meantime?
I'll close this issue as the bug is fixed, but I will notify you when the release/tagging workflow will be available.

@dotdc dotdc closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants