Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected graph labels for internal transitions #587

Open
nightroman opened this issue Jun 30, 2024 · 1 comment
Open

Unexpected graph labels for internal transitions #587

nightroman opened this issue Jun 30, 2024 · 1 comment

Comments

@nightroman
Copy link

nightroman commented Jun 30, 2024

In order to reproduce the issue please use the attached project or use the steps modifying TelephoneCallExample

2024-06-30-0845-TelephoneCallExample.zip

Program.cs - replace this line
with this line, to output the graph "TelephoneCallExample.dll.dot"

    File.WriteAllText($"{typeof(Program).Assembly.Location}.dot", phoneCall.ToDotGraph());

PhoneCall.cs - replace these lines
with these lines, to add description and graph labels "StartCallTimer", "StopCallTimer"

    .OnEntry(t => StartCallTimer(), "StartCallTimer")
    .OnExit(t => StopCallTimer(), "StopCallTimer")

Run the examples and use the created "TelephoneCallExample.dll.dot"

Expected result

The graph shows internal transition labels like this:

SetVolume / [Function]
MuteMicrophone / [Function]
UnmuteMicrophone / [Function]

Actual result

Internal transition labels for some reason now all labeled as "StartCallTimer":

SetVolume / StartCallTimer [Function]
MuteMicrophone / StartCallTimer [Function]
UnmuteMicrophone / StartCallTimer [Function]

NB Interestingly, there are no overloads for setting custom descriptions / labels for internal transitions (or did I miss?).

Here is the result dot converted to svg. Note unexpected internal transition labels "StartCallTimer":
Graphviz

@mclift
Copy link
Member

mclift commented Jul 3, 2024

Thanks for taking the time to report your finding, @nightroman!

PR created for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants