Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermitIf does not support guard actions with more than 3 parameters (list of objects) #598

Open
EraYaN opened this issue Aug 7, 2024 · 0 comments

Comments

@EraYaN
Copy link

EraYaN commented Aug 7, 2024

PermitIf is missing the overload to accept list of objects in the guard delegate. Everywhere else the list of objects is the way to use more than 3 parameters.

Would you be open to a pull request to add this or to add a 4th (and or more) type parameters to all the different functions?
Seems like adding a PermitIf overload that takes object[] in the delegate will break a bunch of downstream stuff like ToPackedGuard. Just adding the 4th, 5th etc type parameters might just be the easier solution.

@EraYaN EraYaN changed the title PermitIf does not support guard actions with more than 4 parameters (list of objects) PermitIf does not support guard actions with more than 3 parameters (list of objects) Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant