Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not-run checks as meeting Maestro policy #4119

Open
premun opened this issue Oct 31, 2024 · 1 comment
Open

Consider not-run checks as meeting Maestro policy #4119

premun opened this issue Oct 31, 2024 · 1 comment

Comments

@premun
Copy link
Member

premun commented Oct 31, 2024

As discussed in #3636 and in #4026, we have problems with Maestro checks not going green when a build is skipped.
We should consider not-run builds as successful but we need to avoid cases where the check is neutral because it hasn't started yet (briefly after a commit is pushed or PR is created).

Example: dotnet/sdk#43972

image

Goal

It seems that we could check the conclusion as well as the status field for that (from the other PR conversation):

"checkRuns": {
  "nodes": [
    {
      "name": "sdk-unified-build",
      "status": "COMPLETED",
      "conclusion": "NEUTRAL"
    },
}

So we need something like #4026 but also verifying the status of the check.

@premun premun changed the title Consider neutral checks as meeting Maestro policy Consider not-run checks as meeting Maestro policy Oct 31, 2024
@premun
Copy link
Member Author

premun commented Oct 31, 2024

@MiYanni @marcpopMSFT there were way too many PRs and issues around this problem. I created this one issue to track this from now on. The rest was mostly closed already.

We will try @MiYanni's proposal from #4026 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant