Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guardrails around classes like VmrInfo for their usage before initialization #4194

Open
dkurepa opened this issue Nov 28, 2024 · 0 comments

Comments

@dkurepa
Copy link
Member

dkurepa commented Nov 28, 2024

PCS supports multiple vmrs (dotnet/dotnet, dotnet-dotnet, maestro-test-vmr...).
We create a scope for every job PCS processes.
The issue with these two facts is that, at the time of creating the scope, we don't know which VMR the subscription wants to use. Because of this, we have classes like VmrCloneManager which are reponsible for making sure we use the correct VMR, and refreshing the metadata classes (VmrInfo, SourceManifest, etc..) with the current VMR data. The issue with this approach is that these metadata classes shouldn't be used before they're refreshed with the latest VMR data.

We want to add some kind of exception throwing guardrails that will help prevent incorrect usage of these classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants