Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Helix images #1365

Open
mthalman opened this issue Feb 19, 2025 · 1 comment
Open

Add unit tests for Helix images #1365

mthalman opened this issue Feb 19, 2025 · 1 comment

Comments

@mthalman
Copy link
Member

This would validate that Helix is correctly configured in these images. There are currently no tests for the images produced by this repo (the Test stage is skipped in the pipeline). But the infrastructure supports this so it's just a matter of defining the tests. And now we do have a place to put them too: https://github.com/dotnet/dotnet-buildtools-prereqs-docker/tree/main/tests/Microsoft.DotNet.BuildTools.Prereqs.Docker.Tests

@dougbu
Copy link
Member

dougbu commented Feb 28, 2025

main Helix requirement is for our Python dependencies to be pre-installed in the Docker containers we use. there's more information about our setup in #1330 but the TL;DR; is we install the helix-scripts to pick up those dependencies. there's a particular focus on dependencies not available as Python binary wheels b/c we don't want or need some of the tools (e.g., Rust) in the Helix Docker images

currently, the requirements.txt files in the helix-scripts wheel is somewhat incomplete. that should improve early next week but I don't think we need to validate the complete set

suggest a few superficial checks like

  1. is $VIRTUAL_ENV defined and pointing to a directory available in the container❓
  2. does $PATH contain $VIRTUAL_ENV/bin or $env:VIRTUAL_ENV\Scripts
  3. does python3 -m pip list | grep -q '^helix-scripts ' or python3 -m pip list | findstr /r /c:"^helix-scripts " succeed❓
  4. perhaps, ask similar questions about the setuptools and requests modules b/c we've had issues w/ both in the past

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants