Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GoogleServicesJson Build Action #1346

Closed
MahmudX opened this issue Jun 17, 2021 · 4 comments
Closed

Add GoogleServicesJson Build Action #1346

MahmudX opened this issue Jun 17, 2021 · 4 comments
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer external s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@MahmudX
Copy link

MahmudX commented Jun 17, 2021

Summary

If we add google-services.json under the android project we should be able to mark it as the GoogleServicesJson file or have any other alternative way.

API Changes

  • Xamarin.GooglePlayServices (AFAIK)

Intended Use Case

To publish Android apps, google-services.json file must be added.
@jsuarezruiz jsuarezruiz added the t/bug Something isn't working label Oct 25, 2021
@hartez hartez added the area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) label Nov 5, 2021
@gianox
Copy link

gianox commented Nov 25, 2021

Relates to [Bug] Java.Interop version issue in Android #3389 ?

@Redth Redth added area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer and removed area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) labels Jan 4, 2022
@Redth
Copy link
Member

Redth commented Jan 4, 2022

Is this suggesting that you can't apply the build action with the file in a Multitargeted/Single Project? The build action comes from https://github.com/xamarin/GooglePlayServicesComponents/blob/d72add8573e5b63dda71ac6b31d3dbdea8b36d67/source/com.google.android.gms/play-services-basement/merge.targets#L18

//CC @moljac @jpobst @jonpryor

@VincentBu VincentBu added the s/verified Verified / Reproducible Issue ready for Engineering Triage label Mar 3, 2022
@Redth Redth added this to the Future milestone Mar 22, 2022
@ghost
Copy link

ghost commented Mar 22, 2022

We've moved this issue to the Future milestone. This means that it is not going to be worked on for the coming release. We will reassess the issue following the current release and consider this item at that time.

@mattleibow mattleibow mentioned this issue Jan 16, 2023
Open
@mattleibow
Copy link
Member

This issue was moved to xamarin/XamarinComponents#1421

@dotnet dotnet locked and limited conversation to collaborators Jan 16, 2023
@mattleibow mattleibow removed this from the Backlog milestone Jan 16, 2023
@samhouts samhouts closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer external s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@Redth @hartez @mattleibow @jsuarezruiz @samhouts @gianox @MahmudX @VincentBu