Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally add the net-sdk-supporting-feed #4687

Open
ViktorHofer opened this issue Oct 22, 2024 · 0 comments · May be fixed by dotnet/sdk#44854
Open

Conditionally add the net-sdk-supporting-feed #4687

ViktorHofer opened this issue Oct 22, 2024 · 0 comments · May be fixed by dotnet/sdk#44854

Comments

@ViktorHofer
Copy link
Member

https://github.com/dotnet/sdk/blob/637380026adba5aac7f29c0ee411f5d9ae207531/src/SourceBuild/content/repo-projects/Directory.Build.targets#L160-L162

Today, the net-sdk-supporting-feed gets always added. It would be better to only add it if the feed isn't listed as a package source. Otherwise this is very confusing as it is preferred over the actual dotnet9 feed and logs mention that feed over the actual feed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
.NET Source Build
Status: Backlog
.NET Unified Build
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update AddSourceToNuGetConfig task dotnet/sdk
1 participant
@ViktorHofer