[StyleCleanUp] Correct file header/license info (IDE0073) #10372
Conversation
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
Yikes, I would not do this |
|
@robert-abeo This isn't anything new, it has been done for multiple .Net projects (See dotnet/runtime#38793 and dotnet/winforms#9615). Personally I don't see anything wrong with it, it's low risk (Can compare the IL to see there isn't any functional changes), doesn't affect git blame (It's mostly just deleted lines) and shouldn't cause conflicts for existing PRs. |
|
I'll just add that anyone concerned with git blame runs with |
|
I wouldn't keep headers. If that's the convention here so be it (its a very old one I wouldn't keep). If you are keeping the headers though I wouldn't remove this: |
Fixes #10371
Description
Puts the file header into correct state, most of the time its removal of the last line, some files didn't have the header at all (ref files).
Customer Impact
Everyone is informed the project is MIT.
Regression
No.
Testing
Local build.
Risk
None, no IL changes.
Microsoft Reviewers: Open in CodeFlow