Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared DataFormats code #10391

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Feb 4, 2025

This uses the shared DataFormats code from System.Private.Windows.Core.

Note that locking is handled by the shared code so there is no need to do so when adding the WPF specific types. The only reason they need added is that casing will stick with whatever the first request is. That is, if you ask for "XAML" that will be the string Windows gives back, not "Xaml".

Microsoft Reviewers: Open in CodeFlow

This uses the shared DataFormats code from System.Private.Windows.Core.

Note that locking is handled by the shared code so there is no need to do so when adding the WPF specific types. The only reason they need added is that casing will stick with whatever the first request is. That is, if you ask for "XAML" that will be the string Windows gives back, not "Xaml".
@JeremyKuhne JeremyKuhne requested review from a team as code owners February 4, 2025 04:22
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 4, 2025
/// Specifies a format that encapsulates any type of Windows Design
/// object. This field is read-only.
/// </summary>
public static readonly string Serializable = "PersistentObject";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataFormatNames.Serializable seems to be WindowsForms10PersistentObject rather than PersistentObject. Isn't that a breaking change?

@miloush
Copy link
Contributor

miloush commented Feb 4, 2025

Where can I see the value of PInvokeCore.INK_SERIALIZED_FORMAT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants