Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap(..., type = "timeline") not working #37

Open
meersel opened this issue Dec 16, 2020 · 4 comments
Open

ap(..., type = "timeline") not working #37

meersel opened this issue Dec 16, 2020 · 4 comments

Comments

@meersel
Copy link

meersel commented Dec 16, 2020

HI ApexCharter Team,

The type = "timeline" option is not working.
No output (read: plot) is displayed.

  • apexcharter package version: 0.1.8.90

  • RMarkdown package version: 2.5

  • R version. : 4.02

  • RStudio: version 1.4.904

  • Windows 10

I have sued the example from Github (see below):

library(apexcharter)
library(tidyverse)

data("presidential", package = "ggplot2")

# Basic

apex(presidential,
mapping = aes(x = name, start = start, end = end),
type = "timeline")

@pvictor
Copy link
Member

pvictor commented Dec 16, 2020

Thanks for reporting it! That's fixed on GitHub version.

Victor

@meersel
Copy link
Author

meersel commented Dec 16, 2020 via email

@meersel
Copy link
Author

meersel commented Dec 16, 2020

tiimeline is now working.

Another bug:
Timeline plot disappears completely if both legends (Democrat and Republican) are deselected.

See R code below for the plot

With groups

# With groups but force position

apex(presidential,
aes(x = name, start = start, end = end, group = party),
"timeline") %>%
ax_xaxis(categories = presidential$name)

@pvictor
Copy link
Member

pvictor commented Dec 17, 2020

I'm afraid that is a bad example, the bug is caused by using categories on x-axis which is apparently not expected...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants