Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mod global #5

Open
3 tasks done
victorpopkov opened this issue Nov 20, 2021 · 0 comments
Open
3 tasks done

Remove mod global #5

victorpopkov opened this issue Nov 20, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@victorpopkov
Copy link
Member

Verify

  • I understand that if I ignore these instructions, my issue may be closed without review.
  • I have made sure that there are no similar opened issues.
  • I have made sure that the mod version matches the latest release.

Is your feature request related to a problem? Please describe.

Consider removing the mod_burningTimer global and pass and pass the values explicitly. In general, we should avoid polluting the global environment without the real necessity, as many things might go wrong. Moreover, it's a best practice to have things isolated and only expose what is needed.

Describe the solution you'd like

Remove mod_burningTimer global.

Describe alternatives you've considered

If applicable, add a clear and concise description of any alternative solutions or features you've considered.

Additional context

If applicable, add any other context or screenshots about the feature request here.

@victorpopkov victorpopkov added the enhancement New feature or request label Nov 20, 2021
@victorpopkov victorpopkov added this to the Release v1.2.0 milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant