Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple limit for checkboxes is not included #15

Open
Daveiano opened this issue Jul 28, 2021 · 2 comments
Open

Multiple limit for checkboxes is not included #15

Daveiano opened this issue Jul 28, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Daveiano
Copy link
Contributor

The "Allowed number of values" is not correctly outputted for checkboxes. The property inside multiple > limit is always 0.

See the following example: I created a webform with three checkboxes fields: The first with an unlimited allowed number of values, the second with a limited allowed number of 2 and a custom error message, the last one with a maximum of 4 and a custom error message. Limit is always 0.

Webform config:
graphql-webform-checkboxes-bug-1

GraphQL Output
graphql-webform-checkboxes-bug-2

@duartegarin
Copy link
Owner

Merged your PR, thanks!

@duartegarin
Copy link
Owner

Wrong issue, reopening!

There is a bug here indeed, the limit being checked in code is a boolean so it always ends up being the same.

Feel free to submit a PR fix, otherwise I'll get to this as soon as I can

@duartegarin duartegarin self-assigned this Jul 29, 2021
@duartegarin duartegarin added the bug Something isn't working label Jul 29, 2021
@Daveiano Daveiano changed the title Multiple limit for checboxes is not included Multiple limit for checkboxes is not included May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants