From c9970305ccce16268209d3d78410cc4b986a0c16 Mon Sep 17 00:00:00 2001 From: Craig Russell Date: Wed, 8 Jan 2025 11:19:00 +0000 Subject: [PATCH] Revert "Allow scrolling all of the password management list mode screen" (#5445) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Task/Issue URL: https://app.asana.com/0/608920331025315/1209106756565265/f ### Description Reverts changes made in https://github.com/duckduckgo/Android/pull/5377 as it introduces performance issues on the password management screen with larger password list sizes. Depending on the device / list size, it can be crippling performance. ### Steps to test this PR - [x] install `internal` variant to make the next step easier - [x] Add 500+ passwords (can be done in `Autofill Dev Settings` screen, using the **Add a lot of sample logins** button) - [x] Visit password management screen and verify there isn’t a huge delay in rendering the password list For contrast, if you try this on `develop` you will notice a large perf issue. Co-authored-by: Craig Russell <1336281+CDRussell@users.noreply.github.com> --- .../main/res/layout/fragment_autofill_management_list_mode.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/autofill/autofill-impl/src/main/res/layout/fragment_autofill_management_list_mode.xml b/autofill/autofill-impl/src/main/res/layout/fragment_autofill_management_list_mode.xml index 5342ee25e29c..970e25b5f97f 100644 --- a/autofill/autofill-impl/src/main/res/layout/fragment_autofill_management_list_mode.xml +++ b/autofill/autofill-impl/src/main/res/layout/fragment_autofill_management_list_mode.xml @@ -78,8 +78,9 @@