From 1117e75fffbfc16c47f435b3312054a077ff12a2 Mon Sep 17 00:00:00 2001 From: Duncan Paterson Date: Wed, 13 Jan 2021 22:45:19 +0100 Subject: [PATCH] chore(test): more gulp todos see #563 --- generators/app/index.js | 3 ++- test/generated-pkg/app-empty.js | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/generators/app/index.js b/generators/app/index.js index 66c9cc8a..f5a246ec 100644 --- a/generators/app/index.js +++ b/generators/app/index.js @@ -943,7 +943,8 @@ module.exports = class extends Generator { this.spawnCommandSync('git', ['add', '--all']) this.spawnCommandSync('git', ['commit', '-q', '-m', '\'initial scaffolding by Yeoman\'']) } - this.spawnCommandSync('ant', '-q') + // TODO: [gulp] line-o make conditional on selected build tool + this.spawnCommandSync('ant', '-q') // TODO: [gulp] line-o conditional gulp watch // if (this.props.apptype[0] === 'polymer') { diff --git a/test/generated-pkg/app-empty.js b/test/generated-pkg/app-empty.js index 7b9431f1..98bc529d 100644 --- a/test/generated-pkg/app-empty.js +++ b/test/generated-pkg/app-empty.js @@ -6,6 +6,9 @@ const fs = require('fs-extra') describe('empty package', function () { this.timeout(15000) + // TODO: #563 [gulp] line-o let's make this the test application for pure gulp build + // we should also add a second app-lib-gulp bringing some of the old polymer file checks + // over and testing the proper gulpfile contents for libs vs apps before(async function () { await helpers.run(path.join(__dirname, '../../generators/app')) .withPrompts({