Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript for this module? #208

Open
truongnat opened this issue Oct 22, 2023 · 2 comments
Open

Add typescript for this module? #208

truongnat opened this issue Oct 22, 2023 · 2 comments

Comments

@truongnat
Copy link

No description provided.

@BobbieGoede
Copy link

@dword-design
I figured I would add some types and use @nuxt/module-builder to build the module and open a PR, but it ended up much more involved than I expected... 😅

I ended up forking the repo and publishing a separate package https://github.com/BobbieGoede/nuxt-mail since I had to change most of the code. Your work is very much appreciated, it's not my intention to compete, maybe moving this module to the nuxt-modules org makes more sense?🤔

@dword-design
Copy link
Owner

@BobbieGoede Looks great! I have some blockers with TypeScript (missing babel plugin support), so I'd not fully migrate to TypeScript now. But we could add a typings file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants