Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Lack of error messages when publishing metrics. [Datadog Native Integration] #1311

Open
sandinocoelho opened this issue May 16, 2023 · 1 comment
Labels
enhancement enhancement to existing feature

Comments

@sandinocoelho
Copy link

sandinocoelho commented May 16, 2023

Describe the bug

Even if the SFPOWERSCRIPTS_DATADOG_HOST is set incorrectly, the command sfpowerscripts:pool:metrics:publish returns 200.

To Reproduce

Set the environment variables as below:

export SFPOWERSCRIPTS_DATADOG=true
export SFPOWERSCRIPTS_DATADOG_HOST=WRONG_VALUE
sfdx sfpowerscripts:pool:metrics:publish -v "$DEVHUB_ALIAS"

Expected behavior

The correct behavior maybe an error message and exit 1 instead of 0.

Screenshots

image

Platform Details (please complete the following information):

  • OS: MacOs
  • Version [e.g. CLI Version eg: 1.6.6] 13.3.1 22E261 arm64
  • Salesforce CLI(sfdx cli) Version: sfdx-cli/7.197.8 darwin-x64 node-v14.19.2
  • CI Platform: Gitlab-CI / Local
@github-actions github-actions bot added the analysis To be decided on how to solution/fix label May 16, 2023
@azlam-abdulsalam
Copy link
Contributor

@sandinocoelho The metrics follow a fire and forget approach. So errors are not handled. I will see how we can improve the experience by writing to an alternate log

@azlam-abdulsalam azlam-abdulsalam added enhancement enhancement to existing feature and removed analysis To be decided on how to solution/fix labels May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants