Why there's so many ways to create a simple button?

[rica-carv]

Why there's so many code scatered across e107 to make something so simple as a single button?

For instance, in news:
PRINTICON
EMAILICON
PDFICON
SOCIALSHARE

in forum:
EMAILITEM
PRINTITEM
REPORTING
EDITIMG
QUOTEIMG

and so on...

Basically, why not reuse the emailprint function to render all sitewide buttons? Currently is only used by PRINTICON and EMAILICON from news, but it works for all the other purposes with some tweaks......

[Moc]

The standard way to use is e107::getForm()->button().

This unfortunately has not been implemented everywhere

A lot of the other icons you mentioned are partly rewritten from old v1 code, but could use standardisation.

[rica-carv]

Thanks @Moc
I'll give it a try...

Meanwhile, i see a small issue with the e107::getForm()->button() function, since it has embebed HTML, and according to BS5 docs the button has it's own HTML tag to be used with BS:

The .btn classes are designed to be used with the element. However, you can also use these classes on or elements (though some browsers may apply a slightly different rendering).

Is by any chance a way to change that function to cover all the possibilities, probably via templates?

Anyway, i'm trying that function to see if it goes the way i want...

[Jimmi08]

Icons with action and buttons are not the same thing (or with the same look). Just note.

[rica-carv]

Icons with action and buttons are not the same thing (or with the same look). Just note.

Indeed @Jimmi08, but a icon with action is bassically a A tag with a image inside it, and a BUTTON tag can have anything inside, even a A tag with a image inside....

Anyway, @Moc , i already find a issue with the e107::getForm()->button() function: it doesn't renders tootlips calls when hovering the button, ie: data-toggle='tooltip' data-bs-toggle='tooltip' title='button hover text'...

Is there by any chance a change inside the code to make it render it?
Or do i need to override the core e107::getForm()->button() function? If so, how can i override the function?

PS: Nevermind, i ended up hacking it with a simple replace... but it's really too bad to have a function to render a HTML tag and that function doesn't support all the tag possibilities....

[Moc]

Please feel free to make suggestions through submitting a PR! Tooltips seem like a good suggestion.

I would rather see the core improved, instead of trying to hack around it using overrides or replaces.

[rica-carv]

Hit another bug, it's also unable to customize the class inside the UL tag... 😞

Comited a PR:#5397

[Jimmi08]

@rica-carv @Moc @Alex-e107nl

Guys, the best solution for form elements was introduced by @CaMer0n with HTML snippets for checkboxes and radios.

Example: (HTML file in theme folder)

<div class="form-check form-check-inline">
    <input type="radio" id="{id}" {attributes} > <span>{label}</span>
</div>

Full theme control of HTML markup and still using form handler and the same method everywhere.

I think this could be used for buttons too. So e107::getForm()->button() can be used as before without worrying about frontend theme markup and classes.

You should look at this solution - look for getSnippet() and renderSnippet() in form handler.

[rica-carv]

Full theme control of HTML markup and still using form handler and the same method everywhere.

@Jimmi08 Ok, i'll give it a look. But at plugin level there's no way to customize the markup, it only works at theme level, right? Well, it's better something than nothing...

But if this is the direction, this means it can be used to any HTML tag output inside e107, replacing the hardcoded HTML that currently his inside any renderbutton function and alikes??
If so, this will need a major rework on the HTML tags creation functions inside the form_handler.php file....

[Jimmi08]

I really don't know what is planned... I only know that it has solved any my troubles with themes. Now all checkboxes work the same way... and just a simple file you can change the look of all them on the whole site. Do you get my point? It was hard at that time to find all the places and check.

If I got it right, there is always a core solution and this is a way how to override it with theme. But important are those {parameters}, there should be the same as PHP version offers with some callback. I took time to get all needed parameters...

For plugins there should be always a callback for boostrap3 or bootstrap 5 - default values respecting standards.

It reminds me HTML templates and shortcodes with simple parsing... just to find all needed shortcodes :)

[rica-carv]

@Moc
Please a guideline here. How should it be donne?

• Like @CaMer0n did with the checkboxes?
• Or like i'm doing here in pr #5391?

Further more, this pr #5397 can use those changes and also use @CaMer0n way?

What do you people think?

[rica-carv]

If I got it right, there is always a core solution and this is a way how to override it with theme.

@Jimmi08 It currently works, if i put those snippets files in my theme. Thanks! I'll probably work my way from here, just waiting for guidelines to continue work....
Thanks once more.... 👍

[rica-carv]

Wow, am i nuts or the snippets files that are on @CaMer0n commits, are not on the base code???

Real weird. The current base code inside the Boostrap3 theme
And the form_checkbox.html that supposedly should be there, no?

What i'm seeing wrong here????

Even when i make the zip for the current code, the files isn't there!
Is that supposed to be like that?