Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance vs Boost #2

Open
stijn-ucrowds opened this issue Jan 19, 2022 · 2 comments
Open

Performance vs Boost #2

stijn-ucrowds opened this issue Jan 19, 2022 · 2 comments

Comments

@stijn-ucrowds
Copy link

stijn-ucrowds commented Jan 19, 2022

Thank you for your work on porting the library over to Rust, it has a lot of potential to simplify voronoi diagram generation in Rust. We've been experimenting with using this library to generate the voronoi diagrams for our application, which so far has resulted in identical output to the C++ version. One issue is that this library is roughly 2x slower

C++ voronoi:   cells:180844, edges:1084654, vertices:361494, in: 1969ms
Rust voronoi:  cells:180844, edges:1084654, vertices:361494, in: 3922ms

Do you have any optimizations in mind? Are there any settings we can tweak?

@stijn-ucrowds
Copy link
Author

It seems like a lot of time is being spent inserting nodes into a linked list. Here is an excerpt from the profiling flame graph.
image

@eadf
Copy link
Owner

eadf commented Oct 22, 2023

Yes, this is probably because of this "hack" that still needs a proper solution: #1
It will, however, take some time for me to look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants