Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error creating voronoi diagram #4

Open
stijn-ucrowds opened this issue May 10, 2022 · 2 comments
Open

Error creating voronoi diagram #4

stijn-ucrowds opened this issue May 10, 2022 · 2 comments

Comments

@stijn-ucrowds
Copy link

stijn-ucrowds commented May 10, 2022

While generating a voronoi diagram I get the error
Err value: InternalError("activate_circle_event could not find node by key 10")
I managed to reduce the crashing input from 272,000 line segments to just 6

50 9270 100 9280
100 9280 4060 9880
220 8290 250 8290
250 8290 270 8300
2730 5630 42700 5920
3240 8740 5210 9040

The data format is a line segment on each line with x1, y1, x2, y2.
I've been trying to debug it, but I'm not too familiar with the internals of voronoi diagram creation so I have been unable to solve it. Would be very nice if you could look at it.

@stijn-ucrowds
Copy link
Author

stijn-ucrowds commented Jun 1, 2022

I found that the issue is with the unique_endpoints calculation in lazy_circle_formation.rs in the pps function. Commenting out that addition (the block of code is new compared with the original boost) restores the loop behaviour to exactly how Boost has it.

@eadf eadf mentioned this issue Oct 31, 2023
@eadf
Copy link
Owner

eadf commented Oct 31, 2023

Thank you for your input.
Yes, i will have to investigate this further, i thought i could be clever and avoid calculating the circle event position occurring between two linked line segments, because the position is already known.
As a workaround i will try to find some time to disable my "improvement"

regards
/Ead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants