Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider switching HprofParser to do 2 passes #8

Open
eaftan opened this issue Feb 7, 2014 · 0 comments
Open

Consider switching HprofParser to do 2 passes #8

eaftan opened this issue Feb 7, 2014 · 0 comments

Comments

@eaftan
Copy link
Owner

eaftan commented Feb 7, 2014

The first pass should just collect class dump info (i.e. build the ClassMap). The second pass can fill in all the values, since we now have the class data.

Currently we are storing all instances in a list, which means we are consuming a lot of memory. This won't work for large heaps.
bogdad added a commit to bogdad/hprof-parser that referenced this issue Dec 23, 2014
@bogdad
Implemented two pass behaviour, no need for instance map any more, see …
6293dd7 
…eaftan#8
bogdad added a commit to bogdad/hprof-parser that referenced this issue Dec 23, 2014
@bogdad
Implemented two pass, as per eaftan#8
d25db7c
bogdad added a commit to bogdad/hprof-parser that referenced this issue Dec 23, 2014
@bogdad
Implemented two pass, as per eaftan#8
453ddde
@bogdad bogdad mentioned this issue Dec 23, 2014
Merged
eaftan added a commit that referenced this issue Oct 10, 2018
@eaftan
Merge pull request #12 from bogdad/twopass2
cd2019e 
Implemented two pass, as per #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eaftan