Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significance tests #638

Open
strengejacke opened this issue May 13, 2024 · 7 comments
Open

Significance tests #638

strengejacke opened this issue May 13, 2024 · 7 comments

Comments

@strengejacke
Copy link
Member

strengejacke commented May 13, 2024

Not sure if you think this fits into effectsize, but I'm missing convenient wrappers around common significance tests, including options to use weights. I have done this for now in sjstats:
https://strengejacke.github.io/sjstats/reference/index.html#summary-statistics-and-tests (e.g. https://strengejacke.github.io/sjstats/reference/chi_squared_test.html).

Let me know what you think. The functions are more or less in easystats style, so would be easy to move over here.

@mattansb
Copy link
Member

I would love to have weights in various effect sizes (#388 ) - do you mean to have a function like t_test() etc?

@bwiernik
Copy link
Contributor

bwiernik commented May 22, 2024

What sort of weights are you thinking about? If we mean survey weights used to adjust for nonresponse or unrepresentative sampling, then we need to ensure that standard errors and significance tests are adjusted appropriately for the weighting design effects (cf. the survey package)

Sorry, I edited your comment instead of the quoted one 🤣

@strengejacke
Copy link
Member Author

I would love to have weights in various effect sizes (#388 ) - do you mean to have a function like t_test() etc?

Yes

@strengejacke
Copy link
Member Author

What sort of weights are you thinking about?

Simple frequency weights.

If we mean survey weights used to adjust for nonresponse or unrepresentative sampling, then we need to ensure that standard errors and significance tests are adjusted appropriately for the weighting design effects (cf. the survey package)

I use this function (or the package) for "simple" weights already, but I think it should, for now, be limited to simple frequency weights.

These kinds of weights are commonly used in my field

@strengejacke
Copy link
Member Author

bump

What's your opinion about having these functions in effectsize?

@mattansb
Copy link
Member

mattansb commented Oct 7, 2024

I'm not sure... It feels out of scope (?) but I can't think of a better place for these in {easystats} (if you're idea was to port those from your sj-verse?)

We can have those here, but I think it should be accompanied by having weighting options for the corresponding effect sizes as well.

@strengejacke
Copy link
Member Author

Ok, make sense. Weighting options make sense in general, even if we don't port the tests from sj to easystats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants