Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tracks and re-adding tracks #87

Open
Noam-Bendelac opened this issue May 18, 2021 · 0 comments
Open

Removed tracks and re-adding tracks #87

Noam-Bendelac opened this issue May 18, 2021 · 0 comments
Labels
backend Backend functionality enhancement New feature or request frontend Frontend functionality
Milestone

Comments

@Noam-Bendelac
Copy link
Collaborator

Noam-Bendelac commented May 18, 2021

  • DB changes
    • Add "re-add" actions to separate chat event actions and situated chat event actions 7ef96f0
    • Also make situated chat event action required, with a "comment" option? Similar idea for separate chat event action 1fc89d3
    • removedTracks array in playlist 7ef96f0
  • Backend changes
  • Rename instances of "tracks" to "present tracks"? To differentiate from removed tracks
  • Frontend rendering
    • New table section
    • Table headers? "Removed tracks" heading? "Removed By" header for the "Added By" column?
  • Frontend "re-add" state in modificationState
  • User guards disallowing actions depending on track state
@Noam-Bendelac Noam-Bendelac added enhancement New feature or request backend Backend functionality frontend Frontend functionality labels May 18, 2021
@Noam-Bendelac Noam-Bendelac added this to the Milestone 2 milestone May 18, 2021
Noam-Bendelac added a commit that referenced this issue May 23, 2021
Refactor api types for track search and tracks within
`.../playlists/:id` to have just the data needed by the frontend, and
move some of the processing from the frontend in several places to the
backend in one place.

These were done together so the draft addition track's data can be
mocked in `SearchResults.tsx` `addButtonOnClick` callback. This will now
allow spotify data on removed tracks to be saved when they are removed
for #87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend functionality enhancement New feature or request frontend Frontend functionality
Projects
None yet
Development

No branches or pull requests

1 participant