Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTW classloader lock prevents multi-thread usage #194

Open
turbanoff opened this issue Nov 20, 2022 · 1 comment
Open

LTW classloader lock prevents multi-thread usage #194

turbanoff opened this issue Nov 20, 2022 · 1 comment

Comments

@turbanoff
Copy link
Contributor

Hello.
In our project we use LTW in development process. Recently we improved one of the part of our application to use multiple thread to load classes (to speed up application start). But results of parallelizing is far from idea. Threads were mostly blocked by this lock:
https://github.com/eclipse/org.aspectj/blob/063d3cc59aad88f02bc82bc6e417a828dae9ef2d/loadtime/src/main/java/org/aspectj/weaver/loadtime/Aj.java#L99
image
It was added in 2006 in this commit - 397a19d in attempt to fix https://bugs.eclipse.org/bugs/show_bug.cgi?id=151182
I wounder if this lock is still required? Or we can drop it to improve LTW performance?. May be it could be replaced with a few different locks instead.
@kriegaex
Copy link
Contributor

@aclement, can you spare some cycles to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turbanoff @kriegaex