Binding of LaunchOptions for GLSP-Server start up

[glsp-bot]

I want to setup the backend launcher, so that the glsp-server is started, when the browser-app is started. For this I followed the implementation in the coffe-editor in project (coffee-server)[https://github.com/eclipsesource/coffee-editor/blob/master/web/coffee-serve].

The (backend-module.ts) [https://github.com/eclipsesource/coffee-editor/blob/master/web/coffee-server/src/node/backend-module.ts] describes two different LaunchOptions (LaunchOptions and GLSPLaunchOption) I understood, that for starting the ecore-glsp-server, I do only need the GLSPLaunchOptions (with a different path to the jar of course) - is that correct?

Following this I removed also the rebinding for the LaunchOption in the constructor (the If-statement in line 24-28).

I wired up the projects correctly and the backend is started correctly. But on the log-output I see an error, that the LaunchOption is undefined:

```ERROR Could not initialize contribution TypeError: Cannot read property 'hostname' of undefined
    at DefaultModelServerClient.prepareBaseUrl (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/@modelserver/theia/lib/node/modelserver-api.js:43:49)
    at DefaultModelServerClient.initialize (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/@modelserver/theia/lib/node/modelserver-api.js:38:14)
    at DefaultModelServerLauncher.initialize (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/@modelserver/theia/lib/node/model-server-backend-contribution.js:43:32)
    at new BackendApplication (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/@theia/core/lib/node/backend-application.js:172:38)
    at _createInstance (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/inversify/lib/resolution/instantiation.js:21:12)
    at Object.resolveInstance (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/inversify/lib/resolution/instantiation.js:41:18)
    at /home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/inversify/lib/resolution/resolver.js:72:42
    at Object.resolve (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/inversify/lib/resolution/resolver.js:96:12)
    at /home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/inversify/lib/container/container.js:319:37
    at Container._get (/home/jonas/Documents/ws19webapp/git/ecore-glsp/client/node_modules/inversify/lib/container/container.js:310:44)```

Though this seems not to be an issue regarding functionality, I wondered why the LaunchOption is undefined. When I looked into modelserver-api.js I saw, that the LaunchOptions are initialized with default values, when they are not explicitly rebound.

Thus, I am wondering if it is necessary to register the GLSPLaunchOption as LaunchOption aswell?
Or is there a misconception on my site regarding which LaunchOptions I need?

The current setup can be inspected (here)[https://github.com/jonny3576/ecore-glsp/tree/docker/client/theia-glsp-server/src/node]

original thread by Jonas Ebel

[tortmayr]

The (backend-module.ts) [https://github.com/eclipsesource/coffee-editor/blob/master/web/coffee-server/src/node/backend-module.ts] describes two different LaunchOptions (LaunchOptions >and GLSPLaunchOption) I understood, that for starting the ecore-glsp-server, I do only need the GLSPLaunchOptions (with a different path to the jar of course) - is that correct?

Yes that's correct. In the coffee editor example LaunchOptions are used for starting the modelserver jar,GLSPLaunchOptionsare used for starting the glsp server. So you only need theGLSPLaunchOptions\

I had a quick look at your code and everything looks fine to me. I think you are receiving this error because you are importing '@modelserver/theia': 'next' in the package.json of 'theia-glsp-server'. This package expects a binding of LaunchOptions hence the exception. Looks like the package is unused in your code anyways so you could simply remove it.