From da6d61b797df50f34f92b7aae5f71aae011f34d3 Mon Sep 17 00:00:00 2001
From: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Date: Wed, 11 Oct 2023 17:26:16 +0200
Subject: [PATCH] Simplified logic in restore method

Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
---
 .../kura/linux/net/iptables/IptablesConfig.java        | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/kura/org.eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/iptables/IptablesConfig.java b/kura/org.eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/iptables/IptablesConfig.java
index 0f00d07d91..1c222354db 100644
--- a/kura/org.eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/iptables/IptablesConfig.java
+++ b/kura/org.eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/iptables/IptablesConfig.java
@@ -628,11 +628,13 @@ private void writeAdditionalRulesToMangleTable(PrintWriter writer) {
      * parsing the iptables configuration file. Only Kura chains are used.
      */
     public void restore() throws KuraException {
-        List<NatPreroutingChainRule> natPreroutingChain = new ArrayList<>();
-        List<NatPostroutingChainRule> natPostroutingChain = new ArrayList<>();
-        List<FilterForwardChainRule> filterForwardChain = new ArrayList<>();
         File iptablesFile = new File(getFirewallConfigFileName());
-        if (iptablesFile.exists()) {
+        if (!iptablesFile.exists()) {
+            return;
+        } else {
+            List<NatPreroutingChainRule> natPreroutingChain = new ArrayList<>();
+            List<NatPostroutingChainRule> natPostroutingChain = new ArrayList<>();
+            List<FilterForwardChainRule> filterForwardChain = new ArrayList<>();
             try (FileReader fr = new FileReader(getFirewallConfigFileName());
                     BufferedReader br = new BufferedReader(fr)) {
                 parseIptablesRules(natPreroutingChain, natPostroutingChain, filterForwardChain, br);