Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP4E always mark code assist as TriggerCharacter if character under cursor is on completionTriggerChars list #799

Open
zulus opened this issue Sep 12, 2023 · 1 comment
Open

LSP4E always mark code assist as TriggerCharacter if character under cursor is on completionTriggerChars list #799

zulus opened this issue Sep 12, 2023 · 1 comment

Comments

@zulus
Copy link
Contributor

zulus commented Sep 12, 2023 •
edited
Loading

This is follow up issue (see #794)

For now, due Eclipse limitation, IContentAssistProcessor never know if it was invoked by character (auto completion), or on demand (assist) so if character under cursor in on completionTriggerChars, LS request is always marked as TriggerCharacter

If assist is invoked by character (via AutoAssistListener which is part of platform ContentAsistant), LS should recive kind: CompletionTriggerKind.TriggerCharacter, is invoked by ctrl/cmd+space LS should receive CompletionTriggerKind.Invoked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zulus