Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Tabs looks greyed out #2182

Closed
jukzi opened this issue Aug 12, 2024 · 14 comments
Closed

Editor Tabs looks greyed out #2182

jukzi opened this issue Aug 12, 2024 · 14 comments
Labels
bug Something isn't working regression Windows Happens on Windows OS

Comments

@jukzi
Copy link
Contributor

jukzi commented Aug 12, 2024

in the past month the File names in the editor changed from black to grey or the used font got thinner then a pixel. Was that intentional? looks less readable
now (I20240811-1800):
image
before (I20240710-1800):
image

Sadly the screenshots are not so good to see the difference due to subpixel rendering. But it was basically the first thing that fleshed my eyes after having not used eclipse for a month.

@jukzi jukzi added bug Something isn't working regression Windows Happens on Windows OS labels Aug 12, 2024
@jukzi
Copy link
Contributor Author

jukzi commented Aug 12, 2024

image

@jukzi
Copy link
Contributor Author

jukzi commented Aug 12, 2024

old black was 0,0,0. new color is 59,59,59
image

@iloveeclipse
Copy link
Member

See #2114

@Phillipus
Copy link
Contributor

Agreed, the text color looks a bit pale now.

@BeckerWdf
Copy link
Contributor

@mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

@mvm-sap
Copy link
Contributor

mvm-sap commented Aug 13, 2024

@mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

Yes, we followed VS Code tab font color codes.
In editor
selected tab : #3b3b3b
unselected tab : #6a6a6a
In Views
Both Selected and Unselected tabs : #3b3b3b

If this does not look good, may be I can try to change

@BeckerWdf
Copy link
Contributor

@mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

Yes, we followed VS Code tab font color codes. In editor selected tab : #3b3b3b unselected tab : #6a6a6a In Views Both Selected and Unselected tabs : #3b3b3b

If this does not look good, may be I can try to change

I really can agree that the contrast of text and background was better in the past. And good contrast is a good think.
Was the color different for selected and unselect tabs before your change?

@mvm-sap
Copy link
Contributor

mvm-sap commented Aug 13, 2024

@mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

Yes, we followed VS Code tab font color codes. In editor selected tab : #3b3b3b unselected tab : #6a6a6a In Views Both Selected and Unselected tabs : #3b3b3b
If this does not look good, may be I can try to change

I really can agree that the contrast of text and background was better in the past. And good contrast is a good think. Was the color different for selected and unselect tabs before your change?

yes, it was #000000 for both selected and unselected tab

@BeckerWdf
Copy link
Contributor

What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs?
What do you think?

@mvm-sap
Copy link
Contributor

mvm-sap commented Aug 13, 2024

What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs? What do you think?

Both in view and editor ?

@BeckerWdf
Copy link
Contributor

What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs? What do you think?

Both in view and editor ?

I would say yes.

@jukzi
Copy link
Contributor Author

jukzi commented Aug 13, 2024

What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs?

Worth a try. But my guess that full contrast is still best for both. The active tab is already emphasized with that blue bar.
image

In general an UI should have high contrast on the active part and lower contrast on the dysfunctional surrounding to focus the reader on the important things. However the eclipse IDE does not follow that design principle. As long as the surrounding views still have high contrast lowering the contrast of the tabs only makes them harder to read without making the user focus on the editor content.
Reducing contrast does only make sense if it is done consistently to serve the purpose of focus.

@BeckerWdf
Copy link
Contributor

This is addressed it in: #2294

@BeckerWdf
Copy link
Contributor

I think this is fixed (see above). Pls. reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Windows Happens on Windows OS
Projects
None yet
Development

No branches or pull requests

5 participants