Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental search might (?) turn the text red after editing and next search #2738

Closed
vogella opened this issue Jan 20, 2025 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@vogella
Copy link
Contributor

vogella commented Jan 20, 2025

I use the find and replay dialog to replace text in an editor.

I search for "Todo" and replace every instance with "Task" using the next button. Now if I search in a text which has no "Todo" with the next next button I would expect that the text gets red as in an initial empty search.

cc @HeikoKlare

Image

@vogella vogella added the bug Something isn't working label Jan 20, 2025
@HeikoKlare
Copy link
Contributor

Can you please explain the workflow to reproduce the issue in a bit more detail, in particular how you did the replacement of "todo" with "task", @vogella?
If I take a document and search for "todo" with the "Search forward" button, then replace every instance with "task" either by manual replacement or via "Replace All" and then search for "todo" again, the search string becomes colored red. That's how I understand the described expected behavior.

Additional question: can you add information about the Eclipse build you are using? I am asking because there was a change regarding coloring in the find/replace overlay like 10 day ago (#2665), so I would like to know whether that change is related to the described issue (be it that the PR may have already fixed it or that it is a regression by that PR).

@vogella
Copy link
Contributor Author

vogella commented Jan 23, 2025

Cannot reproduce anymore with Eclipse SDK
Version: 2025-03 (4.35)
Build id: I20250122-1800
OS: Linux, v.6.8.0-51-generic, x86_64 / gtk 3.24.41
Java vendor: Ubuntu
Java runtime version: 21.0.5+11-Ubuntu-1ubuntu124.04
Java version: 21.0.5

@vogella vogella closed this as completed Jan 23, 2025
@vogella
Copy link
Contributor Author

vogella commented Jan 23, 2025

Thanks @HeikoKlare for the answer. Not reproducable anymore with the latest build for me.

@HeikoKlare
Copy link
Contributor

Thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants