Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page | 'New Applications' Section Displays Apps Randomly Instead of the Most Recent Four Created #1131

Open
tfjanjua opened this issue Nov 6, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tfjanjua
Copy link
Contributor

tfjanjua commented Nov 6, 2024

Current Behavior

Apps are displayed in a random order rather than the most recent four created apps.

Expected Behavior

The section should display the four most recently created apps, sorted by their release date.

Steps To Reproduce

  1. Login to Portal App.
  2. Navigate to the portal home page.
  3. Scroll to the 'New Apps' section.
  4. Observe the order of the applications displayed.
@tfjanjua tfjanjua added the bug Something isn't working label Nov 6, 2024
@tfjanjua tfjanjua self-assigned this Nov 6, 2024
@tfjanjua tfjanjua added this to Portal Nov 6, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Nov 6, 2024
@tfjanjua tfjanjua moved this from NEW USER REQUEST to IN PROGRESS in Portal Nov 6, 2024
tfjanjua added a commit to tfjanjua/portal-backend that referenced this issue Nov 6, 2024
@tfjanjua tfjanjua moved this from IN PROGRESS to IN REVIEW in Portal Nov 6, 2024
@Phil91
Copy link
Member

Phil91 commented Nov 8, 2024

@tfjanjua in my opinion it would make sense to add a sortability to the apps not sure if everyone wants the list to be ordered by the most recent release one. maybe one would sort by name maybe ascending maybe descending or even subscriptions (not sure if that's really a case but think you get my point). But adding a sortability to the list would need frontend adjustments

@MaximilianHauer fyi, what's your opinion on that?

@tfjanjua
Copy link
Contributor Author

@Phil91 , thanks for your feedback, I totally understand your point and I think its really ideal suggestion when this API is been responding data for a sortable list (like tabular list) but FE is been using this API's responded data to show the New Apps so I just thought maybe in this case we should get the ordered list from BE in anyways so, only New Apps could have been shown.

but lets wait for @MaximilianHauer response.

@ntruchsess
Copy link
Contributor

ntruchsess commented Nov 14, 2024

@Phil91 @MaximilianHauer from my point of view we should merge #1132 as it is as having a predefined sorting order cannot be worse than having no defined sorting order at all (which is the case now).
Nevertheless we may consider @Phil91 's suggestion to add a parameter to the api that allows to define the sortingorder dynamically (we do have this in lots of other places and it's easy to implement, but obviously it requires frontend-changes to make a difference). From my point of view this can also be done after merge of PR #1132 with no negative side-effects. Just needs a clear definition of the deliverables in respective ticket(s).

@Phil91
Copy link
Member

Phil91 commented Nov 14, 2024

@ntruchsess would agree that we can merge #1132 since it doesn't do any damage

@ntruchsess ntruchsess added this to the Release 25.03 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: IN REVIEW
Development

No branches or pull requests

3 participants