Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential has wrong status after approval #285

Closed
Phil91 opened this issue Oct 22, 2024 · 3 comments
Closed

Credential has wrong status after approval #285

Phil91 opened this issue Oct 22, 2024 · 3 comments
Assignees
@Phil91
Labels
bug Something isn't working
Milestone
Release 1.2.0 (24...

Comments

@Phil91
Copy link
Member

Phil91 commented Oct 22, 2024

Current Behavior

When approving a framework credential it is directly set to active, even if it isn't existing in the wallet.

Expected Behavior

The credential should only be active if it is existing in the wallet

Steps To Reproduce

Create a credential, approve the credential with a not running process worker. The credential is set to active
@Phil91 Phil91 added the bug Something isn't working label Oct 22, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Oct 22, 2024
@Phil91 Phil91 self-assigned this Oct 22, 2024
@Phil91 Phil91 moved this from NEW USER REQUEST to IN PROGRESS in Portal Oct 22, 2024
@Phil91 Phil91 added this to the Release 24.12 milestone Oct 22, 2024
Phil91 added a commit that referenced this issue Oct 22, 2024
@Phil91
bug: set credential to active after credential exists
9b90e2f 
Refs: #285
@evegufy
Copy link
Contributor

evegufy commented Oct 23, 2024

@Phil91 just wondering, did you forget to open a PR for 9b90e2f? :)

@Phil91 Phil91 mentioned this issue Oct 23, 2024
Merged
9 tasks
@Phil91
Copy link
Member Author

Phil91 commented Oct 23, 2024

@Phil91 just wondering, did you forget to open a PR for 9b90e2f? :)

I actually did - sorry, it's created now: #286

Phil91 added a commit that referenced this issue Oct 24, 2024
@Phil91
bug: set credential to active after credential exists (#286)
af759bf 
Refs: #285
Reviewed-By: Evelyn Gurschler <[email protected]>
@Phil91 Phil91 moved this from IN PROGRESS to USER READY in Portal Nov 11, 2024
@evegufy
Copy link
Contributor

evegufy commented Nov 14, 2024

we noticed that the change, should be accompanied by some usability improvements:

@evegufy evegufy closed this as completed Nov 14, 2024
@evegufy evegufy changed the title credential has wrong status after approval Credential has wrong status after approval Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phil91 Phil91

Labels
bug Something isn't working
Projects
Portal
Status: USER READY
Milestone
Release 1.2.0 (24.12)
Development

No branches or pull requests
2 participants
@Phil91 @evegufy