-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClickHouse DB support #923
Comments
@smagellan I'm curious to know how is click house implemented ? |
I don't know about ClickHouse internals a lot. In general - it is columnar-oriented analytical db: https://github.com/ClickHouse/ClickHouse/. Most SELECT's are extremely fast. P.S. driver dev branch is here: https://github.com/smagellan/vertx-sql-client/tree/feature/clickhouse-native-client |
it seems like a lot of work, can you point out the protocol documentation you used to implement this ? |
Protocol is described here: https://clickhouse.tech/docs/en/interfaces/tcp/. In short: I played with console client, wireshark, https://github.com/ClickHouse/ClickHouse/tree/master/src/Client and https://github.com/mymarilyn/clickhouse-driver |
Hope I will create PR(into ClickHouse repo) with protocol documentation later |
ok, would you support this contribution then in the SQL client ? |
Yes, I would |
can you ping me privately ? |
Sure, sent you an e-mail |
Hi @smagellan , I've postponed this to 4.3.0. It would be great to land this in the next minor version. Can you confirm you can do it? |
Hello @tsegismont. Sure. Although I can't do that alone (Where is a merge button anyway?). |
@vietj / @smagellan is there any traction on this? Were you able to get it reviewed? I see loads of conflicts now... |
Read me
Read this first before creating an issue:
Describe the feature
ClickHouse native(binary) driver
Use cases
ClickHouse is a pretty popular analytical db, so driver should be useful
Contribution
I am OK to implement that. In fact, I managed to run tck without errors without transaction test(s) since transactions are not supported by DB at the moment. Need to implement encoding of remaining types though
The text was updated successfully, but these errors were encountered: