Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse DB support #923

Open
smagellan opened this issue Mar 23, 2021 · 13 comments
Open

ClickHouse DB support #923

smagellan opened this issue Mar 23, 2021 · 13 comments
Milestone

Comments

@smagellan
Copy link

Read me

Read this first before creating an issue:

  • do not use this issue tracker to ask questions, instead use one of these channels. Questions will likely be closed without notice.
  • you shall create a feature request only when it is general purpose enough.
  • make sure that the feature is not already

Describe the feature

ClickHouse native(binary) driver

Use cases

ClickHouse is a pretty popular analytical db, so driver should be useful

Contribution

I am OK to implement that. In fact, I managed to run tck without errors without transaction test(s) since transactions are not supported by DB at the moment. Need to implement encoding of remaining types though

@vietj
Copy link
Member

vietj commented Mar 25, 2021

@smagellan I'm curious to know how is click house implemented ?

@vietj vietj added this to the 4.1.0 milestone Mar 25, 2021
@smagellan
Copy link
Author

I don't know about ClickHouse internals a lot. In general - it is columnar-oriented analytical db: https://github.com/ClickHouse/ClickHouse/. Most SELECT's are extremely fast.

P.S. driver dev branch is here: https://github.com/smagellan/vertx-sql-client/tree/feature/clickhouse-native-client

@vietj
Copy link
Member

vietj commented Mar 25, 2021

it seems like a lot of work, can you point out the protocol documentation you used to implement this ?

@smagellan
Copy link
Author

@smagellan
Copy link
Author

Hope I will create PR(into ClickHouse repo) with protocol documentation later

@vietj
Copy link
Member

vietj commented Mar 25, 2021

ok, would you support this contribution then in the SQL client ?

@smagellan
Copy link
Author

Yes, I would

@vietj
Copy link
Member

vietj commented Mar 25, 2021

can you ping me privately ?

@smagellan
Copy link
Author

Sure, sent you an e-mail

@vietj vietj modified the milestones: 4.1.0, 4.1.1 Jun 1, 2021
@vietj vietj modified the milestones: 4.1.1, 4.2.0 Jul 2, 2021
@tsegismont tsegismont modified the milestones: 4.2.0, 4.3.0 Oct 14, 2021
@tsegismont
Copy link
Contributor

Hi @smagellan , I've postponed this to 4.3.0.

It would be great to land this in the next minor version. Can you confirm you can do it?

@smagellan
Copy link
Author

smagellan commented Oct 14, 2021

Hello @tsegismont. Sure. Although I can't do that alone (Where is a merge button anyway?).

@vietj vietj modified the milestones: 4.3.0, 4.3.1 May 12, 2022
@vietj vietj modified the milestones: 4.3.1, 4.3.2 May 25, 2022
@vietj vietj modified the milestones: 4.3.2, 4.3.3 Jul 6, 2022
@vietj vietj modified the milestones: 4.3.3, 4.3.4 Aug 9, 2022
@vietj vietj modified the milestones: 4.3.4, 4.3.5 Oct 1, 2022
@vietj vietj added this to the 4.4.5 milestone Jun 22, 2023
@vietj vietj modified the milestones: 4.4.5, 4.4.6 Aug 30, 2023
@vietj vietj modified the milestones: 4.4.6, 4.5.0 Sep 12, 2023
@vietj vietj modified the milestones: 4.5.0, 4.5.1 Nov 15, 2023
@vietj vietj modified the milestones: 4.5.1, 4.5.2 Dec 13, 2023
@vietj vietj modified the milestones: 4.5.2, 4.5.3 Jan 30, 2024
@UbiquitousBear
Copy link

@vietj / @smagellan is there any traction on this? Were you able to get it reviewed? I see loads of conflicts now...

@vietj vietj modified the milestones: 4.5.3, 4.5.4 Feb 6, 2024
@vietj vietj modified the milestones: 4.5.4, 4.5.5 Feb 22, 2024
@vietj vietj modified the milestones: 4.5.5, 4.5.6 Mar 14, 2024
@vietj vietj modified the milestones: 4.5.6, 4.5.7, 4.5.8 Mar 21, 2024
@vietj vietj modified the milestones: 4.5.8, 4.5.9 May 24, 2024
@vietj vietj modified the milestones: 4.5.9, 4.5.10 Jul 17, 2024
@vietj vietj modified the milestones: 4.5.10, 4.5.11 Sep 4, 2024
@vietj vietj modified the milestones: 4.5.11, 4.5.12 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants